Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2920: don't modify headers when calling cookies #2922

Closed
wants to merge 1 commit into from
Closed

Fix #2920: don't modify headers when calling cookies #2922

wants to merge 1 commit into from
+3 −3

Conversation

asterite
Copy link
Member

Response headers shouldn't be modified when asking its cookies, otherwise headers can't be easily forwarded.

Fix #2920: don't modify headers when calling cookies

Verified

This commit was signed with the committer’s verified signature. The key has expired.
WilliButz
GPG key ID: 92582A10F1179CB2
Expired
Verified
Learn about vigilant mode
c2c916c
@jhass
Copy link
Member

jhass commented Jun 27, 2016

I'm sure it made more sense at some point :P Guess things changed since.

@asterite
Copy link
Member Author

One used to return an HTTP::Response instance in the http server, maybe back then it made sense... to keep the cookies info in a single place. But still, I don't know why was that for. In any case, when serializing the request or response objects the header is updated. Maybe @jreinert would know more, as he coded the original functionality, but I think it's fine if we merge this.

@asterite
Copy link
Member Author

Merged in ccf90f7

@asterite asterite closed this Jun 27, 2016
@asterite asterite deleted the feature/fix_2920 branch July 3, 2016 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic:stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asterite @jhass