Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PDLPorters/pdl
base: d12d7b1a8682
Choose a base ref
...
head repository: PDLPorters/pdl
compare: dcebe92dc4b1
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jun 28, 2016

  1. Prevent segfault when qsort etc called with a scalar argument 

    If a user mistakenly passed a perl scalar argument to qsort and
its ilk, the SV would be mistaken for a piddle and passed to
the underlying generic_qsort etc routines. Not surprisingly,
those routine's array index tricks would cause a segfault. This
commit causes qsort, qsorti, qsortvec, and qsortveci to barf
if an argument is passed with incorrect dimensions.

Some care is taken to allow trivial sorts.

2 tests for each routine have been added, and some existing
tests labeled.
    @d-lamb
    d-lamb committed Jun 28, 2016
    Copy the full SHA
    40d21cb View commit details
    Browse the repository at this point in the history

  2. Change pdl_barf to PDL->pdl_barf in ufunc.pd. 

    Hopefully this will compile on Strawberry. Not sure why the original
worked OK on my Mac w/ clang.
    @d-lamb
    d-lamb committed Jun 28, 2016
    Copy the full SHA
    dcebe92 View commit details
    Browse the repository at this point in the history