Change delegate macro to be delegate *methods, to: object
#2786
+169
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -730,7 +730,7 @@ class String | |||
| end | |||
|
|
|||
| def at(index : Int) | |||
| at(index) { raise IndexError } | |||
| at(index) { raise IndexError.new } | |||
There was a problem hiding this comment.
Ah, it was wrong. Maybe I should commit the fix to master instead :-P
asterite
force-pushed
the
feature/delegate_to
branch
from
649afa6 to
d3ae73e
Compare
asterite
force-pushed
the
feature/delegate_to
branch
from
d3ae73e to
1cbb700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the way I wanted
delegateto work in the first place, though the language couldn't express that.This is a breaking change, but it makes code easier to read and understand:
Additionally, an extra overload that receives a block is added, which forwards all block arguments, so this covers now all cases except that when a block is captured.