Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Preinstall make in docker image #2897

Closed
wants to merge 1 commit into from
Closed

Docker: Preinstall make in docker image #2897

wants to merge 1 commit into from
+1 −1

Conversation

splattael
Copy link
Contributor

Most Crystal projects use make anyway so you don't have to do it manually.

@ysbaddaden
Copy link
Contributor

Isn't build-essential already installing it?

@splattael
Copy link
Contributor Author

@ysbaddaden Oops, you are right! I will remove it there and only keep it in Dockerfile.release.

Thanks 👍

Docker: Preinstall make in docker image
f066085 
Most Crystal projects use `make` anyway so you don't have to do it manually.
@splattael
Copy link
Contributor Author

Anything I can do to get this merged? 💚

@asterite
Copy link
Member

@splattael Yes, please send a friendly reminder in a comment (like the above one) 😸

Merged in eb27aad

Thanks! ❤️

@asterite asterite closed this Jun 28, 2016
@jhass jhass added this to the 0.18.6 milestone Jun 28, 2016
@splattael
Copy link
Contributor Author

Thanks for merging! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic:infrastructure
Projects
None yet
Milestone
0.18.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@splattael @ysbaddaden @asterite @jhass