Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Deprecate Post.section_link(). #2111

Merged
merged 2 commits into from Sep 22, 2015
Merged

WIP: Deprecate Post.section_link(). #2111

merged 2 commits into from Sep 22, 2015

Conversation

felixfontein
Copy link
Contributor

WIP for #2086.

Where should this go in CHANGES.txt? Is this a feature or a bug? :)

@@ -744,7 +744,7 @@ def section_color(self, lang=None):
return utils.colorize_str_from_base_color(slug, base)

def section_link(self, lang=None):
"""Return the link to the post's section."""
"""Return the link to the post's section (deprecated)."""
if lang is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use a deprecation warning (logger.warning if we can access that)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils.LOGGER is available.

@Kwpolska
Copy link
Member

Add a different changelog section for this, at the end, named Deprecations, I guess?

Also, please make a commit with fix #2086 in the message.

Kwpolska added a commit that referenced this pull request Sep 22, 2015
WIP: Deprecate `Post.section_link()`.
@Kwpolska Kwpolska merged commit 8840c71 into master Sep 22, 2015
@Kwpolska Kwpolska deleted the deprecate-section-link branch September 22, 2015 18:37
@Kwpolska
Copy link
Member

Thanks!

@felixfontein
Copy link
Contributor Author

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants