Fix #2094 - scaling and colorbox of SVG thumbnails #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tree.attrib['width'] = "%ipx" % w | ||
| tree.attrib['height'] = "%ipx" % h | ||
| tree.attrib['viewport'] = "0 0 %ipx %ipx" % (w, h) | ||
| if dst.endswith('.tgz'): |
|
Sorry, the tgz was a mistake of course. |
|
LGTM, Any comments @Aeyoun ? If not, let's merge this on monday. |
|
Looks saner than most things involving SVGs. 👍 |
|
Ok, @TyberiusPrime add a one-line in CHANGES, add yourself to AUTHORS, fix the conflict and ping me here, I'll merge. |
|
ping :) |
ralsina
added a commit
that referenced
this pull request
Sep 21, 2015
Fix #2094 - scaling and colorbox of SVG thumbnails
|
Merged, thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change rescales SVGs by manipulating their width, height and viewport.
It extracts width and height from the parse tree, throws away the units, calculates aspect ratio
and rewrites them accordingly in px.
To enable colorbox-functionality for SVG thumbnails, the thumbnail plugin confuses docutils
to treat svgs like other images by appending a '?' to the uri.