This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Threaded modmail parameter #1454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one to get modmail in it's threaded form via the API, which can be useful depending on how the user works.
Looks like [this](http://imgur.com/a/pS8Lu)
Looks like [this](http://i.imgur.com/IHLbssN.png)
|
Thanks for the contribution - I think we need to close this so that we can have a larger discussion about threaded modmail in general, though. Also just as an aside this isn't the way we intend for feature flags to be used: they're typically for short-to-medium term things that need to go out to a segment of people. In this case we'd need to keep this feature flag around forever, which would have deleterious effects on code quality and also having a bunch of flags like that ends up being not great for zookeeper performance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to get modmail in it's threaded form via the API, which can be useful depending on how the user works.
(Of course, without having to constantly enable the user preference if they for whatever reason want flat modmail)
I've also added two different commits for a GUI to select threaded modmail via the browser. If you'd like the first, just disregard the second. If you'd like the second, squash the third commit with the second. If you'd like neither, disregard both :P.
E: of course, the line in example.ini would have to be moved to reddit's run.ini