Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1772 #1773

Merged
merged 2 commits into from Jun 1, 2015
Merged

Fix #1772 #1773

merged 2 commits into from Jun 1, 2015

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Jun 1, 2015

Looks like scale_images was creating files without telling doit, and check found it :-)

@ralsina
Copy link
Member Author

ralsina commented Jun 1, 2015

@Kwpolska any ideas why appveyor fails here?

ralsina added a commit that referenced this pull request Jun 1, 2015
@ralsina
Merge pull request #1773 from getnikola/fix-1772
2c97f16 
Fix #1772
@ralsina ralsina merged commit 2c97f16 into master Jun 1, 2015
@ralsina ralsina deleted the fix-1772 branch June 1, 2015 13:22
@Kwpolska
Copy link
Member

Kwpolska commented Jun 1, 2015

@ralsina it seems to be a regression introduced on the smarter-check branch:

[2015-05-31T14:09:19Z] WARNING: check: Broken link in output\listings\index.html: https://example.com/foo/listings/index.html.html

There is probably something crazy going on with link creation in listings.

@ralsina
Copy link
Member Author

ralsina commented Jun 1, 2015

Actually, that was an undetected broken link, maybe my fix was not good tho. I'll check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralsina @Kwpolska