Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensmtpd module: allow changing the package #42153

Merged
merged 1 commit into from
Jun 18, 2018
Merged

opensmtpd module: allow changing the package #42153

merged 1 commit into from
Jun 18, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Jun 18, 2018

Motivation for this change

With the recent dovecot-OpenSMTPD breakage it'd have been nice to have this. I wonder whether this should be backported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis merged commit 2f907d5 into NixOS:master Jun 18, 2018
@adisbladis
Copy link
Member

Thanks!

I have backported this change to 18.03 in 9898840.

@Ekleog
Copy link
Member Author

Ekleog commented Jun 18, 2018

Thank you!

@Ekleog Ekleog deleted the opensmtpd-changeable-package branch June 18, 2018 08:57
@infinisil infinisil mentioned this pull request Nov 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @adisbladis @GrahamcOfBorg