Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 864a3a69a48f
Choose a base ref
...
head repository: jruby/jruby
compare: 6dc0f91e959d
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Sep 12, 2016

  1. [Truffle] All known encoding names are US-ASCII. 

    While it's possible in theory to have a new encoding using non-ASCII names, all of the ones in jCodings are US-ASCII and MRI returns US-ASCII for the names of each encoding. Switching to US-ASCII avoids a code range scan, since an ASCII-8BIT string can be either CR_7BIT or CR_VALID, while US-ASCII can only be CR_7BIT. Also, since the jCodings names can't change, there's no need to make a defensive copy here, so we can do away with the unnecessary ByteList allocation.
    @nirvdrum
    nirvdrum committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    c7fdb07 View commit details
    Browse the repository at this point in the history

  2. [Truffle] Removed unnecessary ByteList allocation. 

    This also avoids the defensive copy of memory we make when converting a rope to a ByteList.
    @nirvdrum
    nirvdrum committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    6dc0f91 View commit details
    Browse the repository at this point in the history