pythonPackages.django_accept_header: init at 0.3.2 #18960
Closed
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Sep 25, 2016
| meta = { | ||
| descriotion = "A Django middleware that inspects the HTTP Accept headers sent by browsers"; | ||
| homepage = https://github.com/fladi/django-accept-header; | ||
| license = lib.licenses.free; # ISC License (ISCL), MIT like |
There was a problem hiding this comment.
stdenv.lib.licenses.free, see travis
lsix
force-pushed
the
add_django_accept_header
branch
from
d0c2ea5 to
81562f0
Compare
|
are the tests run? Just asking because you added pytest. |
kevincox
approved these changes
Sep 26, 2016
|
Sorry for late reply (quite busy those time) Actually, the check phase do not find tests to run, but py.test it required as an install requirement… That is not the optimal solution since I should make sure that the tests are actually ran. I’ll look into that, ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)