Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 3b556f6cb228
Choose a base ref
...
head repository: jruby/jruby
compare: b9bcb01ecd81
Choose a head ref
  • 5 commits
  • 3 files changed
  • 2 contributors

Commits on Sep 12, 2016

  1. avoid eager secure random initialization on every new Ruby thread all… 

    …ocation

shaves off 10-15% of Thread.new/start :

```
Rehearsal ----------------------------------------------------------
Thread.new [100000x]    12.800000   6.850000  19.650000 ( 10.392600)
Thread.start [100000x]  12.670000   5.680000  18.350000 (  9.625846)
------------------------------------------------ total: 38.000000sec

                             user     system      total        real
Thread.new [100000x]    12.780000   5.760000  18.540000 (  9.620000)
Thread.start [100000x]  12.490000   5.810000  18.300000 (  9.524975)
```

```
Rehearsal ----------------------------------------------------------
Thread.new [100000x]    11.040000   5.560000  16.600000 (  8.708792)
Thread.start [100000x]  10.740000   5.520000  16.260000 (  8.400990)
------------------------------------------------ total: 32.860000sec

                             user     system      total        real
Thread.new [100000x]    10.840000   5.620000  16.460000 (  8.506339)
Thread.start [100000x]  10.460000   5.560000  16.020000 (  8.323819)
```
    @kares @headius
    kares authored and headius committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    8fb4b93 View commit details
    Browse the repository at this point in the history

  2. Prefer non-blocking PRNG, with failover to SHA1 and then JDK def. 

    See #1405.
    @headius
    headius committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    4e076c1 View commit details
    Browse the repository at this point in the history

  3. Actually settle on SHA1PRNG if it's available. #1405 

    I botched the previous patch a bit by unconditionally re-assigning
the secureRandom local to a default JDK new SecureRandom. This
could cause systems without the default preferred PRNG
(NativePRNGNonBlocking, Java 8+) to have slower thread startup and/or
random number generation.
    @headius
    headius committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    2af75fa View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2016

  1. Provide a help string that makes sense for PRNG option.

    @headius
    headius committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    09dcb93 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2016

  1. Merge pull request #4149 from headius/backport_securerandom 

    Backport securerandom
    @headius
    headius committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    b9bcb01 View commit details
    Browse the repository at this point in the history