Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 005a9027a595
Choose a base ref
...
head repository: jruby/jruby
compare: 994a8a276e1e
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Sep 14, 2016

  1. Stop using WrapperMethod, since it messes up super logic. 

    This is for #3869 and relates to the module_function change from
and redefine it with a new visibility and implementation class.
However the impl class never passed through to the contained
method, preventing it from being used in super. This affected, for
example, module_fuction singleton methods that need to super or
methods transplanted using defined_method with a Method instance.
The new logic always tries to dup the target method so it can
be truly populated with the altered fields. This change fixed

The previous commit, using cloning instead of construction for
IR methods, works around the fact that there's no semi-transparent
WrapperMethod to delegate its serial number to the wrapped method.
Since in that case and in this one, the method's serial number
was expected to be the same after duplication, the clone
technique seems acceptable.

jruby-1_7: Fixes #4155
    @headius
    headius committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    f11ea4b View commit details
    Browse the repository at this point in the history

  2. Remove remaining uses of WrapperMethod.

    @headius
    headius committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    994a8a2 View commit details
    Browse the repository at this point in the history