Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3197 #3212

Conversation

ozra
Copy link
Contributor

@ozra ozra commented Aug 29, 2016

No description provided.

@ysbaddaden
Copy link
Contributor

Look great, but I'd like @asterite to look at this first :-)

@ozra
Copy link
Contributor Author

ozra commented Aug 31, 2016

Yes, I think that's best too; it works, but it might not "be the right place for solving it" B-) I'm still far from groking the semantic parts of the compiler.

@asterite
Copy link
Member

asterite commented Sep 1, 2016

@ozra Thank you, the fix is OK :-)

There's no need to only remove_alias if it's an AliasType: the method is also defined on Type as returning self.

Lately I'm trying to document the compiler as much as I can. Ideally anyone should be able to jump in and understand the code (I honestly believe it's not that complex). But it might take a while for me to do so.

@asterite asterite merged commit 4f810f2 into crystal-lang:master Sep 1, 2016
@ozra
Copy link
Contributor Author

ozra commented Sep 2, 2016

Yes, I've seen more and more comments - they're really helpful in acquainting the terrain! Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants