ruby: remove 1.9 (WIP) #18385
ruby: remove 1.9 (WIP) #18385
Conversation
Remove ruby 1.9 since it is EOLed upstream
|
cc @zimbatm |
| , name ? "sdformat-${version}" | ||
| , version ? "4.0.0" # versions known to work with this expression include 3.7.0 | ||
| , srchash-sha256 ? "b0f94bb40b0d83e35ff250a7916fdfd6df5cdc1e60c47bc53dd2da5e2378163e" | ||
| , ... | ||
| }: | ||
|
|
||
| let | ||
| ruby = ruby_1_9; |
There was a problem hiding this comment.
I bet there is a reason why it had been set to ruby 1.9. Did you test this library?
There was a problem hiding this comment.
Maybe @pxc knows. He's the implicit maintainer as the gazebo package is the only one depending on this lib.
There was a problem hiding this comment.
No, I only checked that it compiled fine. I will check this and get back.
|
Good idea. 👍 |
|
Any news here? |
|
@fpletz I am currently on a slow and sporadic internet connection (this month and for the next month too). Hence I have been unable to move forward on this. I changed the title to WIP, and can close it for now and reopen it later if that is better. |
|
Any progress? |
|
Rebased and merged into master. sdformat is marked as broken until @pxc fixes it. |
|
Not sure which user you want to notify @zimbatm but it's not me ;-) |
Motivation for this change
Ruby 1.9 is EOLd by upstream
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)