Deprecate framed invoke #4139
Merged
Deprecate framed invoke #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has worked for the JIT and it runs almost all the same tests as the interpreter. See jruby#4134.
This is in response to callers not seting up frame and breaking visibility checks in jruby#4134. This goes along with jruby#4138.
|
Note that only one of the commits in this PR is actually from this PR...the other three are from #4138. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the "invoke" forms in Helpers and RubyClass that depended on having a Ruby frame pushed to get "self" for visibility checking. Improper use of this method (in this case, frame was eliminated) caused #4134.
This PR is expected to be applied after #4138, which fixes #4134 by changing attribute assigns to use a CallSite like any other invocation.