Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale rubyspec tags #4151

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Remove stale rubyspec tags #4151

merged 1 commit into from
Sep 13, 2016

Conversation

etehtsea
Copy link
Contributor

No description provided.

@kares
Copy link
Member

kares commented Sep 13, 2016

module specs and an io spec seems to fail :

     [exec] 1)
     [exec] IO#each with limit when limit is 0 raises an ArgumentError FAILED
     [exec] Expected ArgumentError but no exception was raised (#<IO:0xa54c14d> was returned)
     [exec] /home/travis/build/jruby/jruby/spec/ruby/core/io/shared/each.rb:77:in `block in (root)'
     [exec] org/jruby/RubyBasicObject.java:1667:in `instance_eval'
     [exec] org/jruby/RubyEnumerable.java:1589:in `all?'
     [exec] org/jruby/RubyFixnum.java:299:in `times'
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] /home/travis/build/jruby/jruby/spec/ruby/core/io/each_spec.rb:5:in `<main>'
     [exec] org/jruby/RubyKernel.java:974:in `load'
     [exec] org/jruby/RubyBasicObject.java:1667:in `instance_eval'
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] 
     [exec] 2)
     [exec] Numeric#% returns self - other * self.div(other) ERROR
     [exec] NoMethodError: undefined method `%' for #<NumericMockObject:0x103560e1 @null=nil, @name="self">
     [exec] org/jruby/RubyBasicObject.java:1633:in `method_missing'
     [exec] /home/travis/build/jruby/jruby/spec/ruby/core/numeric/modulo_spec.rb:14:in `block in (root)'
     [exec] org/jruby/RubyBasicObject.java:1667:in `instance_eval'
     [exec] org/jruby/RubyEnumerable.java:1589:in `all?'
     [exec] org/jruby/RubyFixnum.java:299:in `times'
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] /home/travis/build/jruby/jruby/spec/ruby/core/numeric/modulo_spec.rb:22:in `<main>'
     [exec] org/jruby/RubyKernel.java:974:in `load'
     [exec] org/jruby/RubyBasicObject.java:1667:in `instance_eval'
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] 
     [exec] 3)
     [exec] An exception occurred during: Mock.verify_count
     [exec] Numeric#% returns self - other * self.div(other) FAILED
     [exec] Mock 'self' expected to receive 'div' exactly 1 times but received it 0 times
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] org/jruby/RubyHash.java:1344:in `each'
     [exec] org/jruby/RubyBasicObject.java:1667:in `instance_eval'
     [exec] org/jruby/RubyEnumerable.java:1589:in `all?'
     [exec] org/jruby/RubyFixnum.java:299:in `times'
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] /home/travis/build/jruby/jruby/spec/ruby/core/numeric/modulo_spec.rb:22:in `<main>'
     [exec] org/jruby/RubyKernel.java:974:in `load'
     [exec] org/jruby/RubyBasicObject.java:1667:in `instance_eval'
     [exec] org/jruby/RubyArray.java:1734:in `each'

... also did you test this on Windows (since you removed some windows: tagged) ?

@etehtsea
Copy link
Contributor Author

etehtsea commented Sep 13, 2016

@kares This is strange, because mspec tag --purge should remove tags that don't match to any specs anymore.

       --purge                Remove all tags not matching any specs

@eregon could you please help, maybe I got it wrong.

@etehtsea
Copy link
Contributor Author

@kares okay, I left windows tags intact, because I couldn't run specs on windows (I tried but all tasks failed with various errors).

@headius
Copy link
Member

headius commented Sep 13, 2016

Wow...I love to see tags go away :-) Once this runs green we'll merge. Thanks for restoring the Windows tags.

@etehtsea
Copy link
Contributor Author

@headius travis is green

@headius headius merged commit 08aa0c4 into jruby:master Sep 13, 2016
@headius
Copy link
Member

headius commented Sep 13, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants