Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos config: Add environment.xdg.mimeTypes #18551

Closed
wants to merge 1 commit into from
Closed

nixos config: Add environment.xdg.mimeTypes #18551

wants to merge 1 commit into from

Conversation

sheenobu
Copy link
Contributor

@sheenobu sheenobu commented Sep 13, 2016 •
edited

Motivation for this change

Initial work for #18422, "XDG Configuration / Declarative Mime Types"

Notes:

  • The perl script is terrible, and the XML that is created is poorly formatted (but valid XML).
  • This doesn't (yet) help package maintainers who want to declare their own custom mimeTypes within mkDerivation. I imagine that would be under pkgs/build-support/
  • "match" is a no-op, and the "magic" section is not yet implemented.
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@sheenobu, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers

@Mic92
Copy link
Member

Mic92 commented Oct 22, 2016 •
edited

To be honest this reminds me of #19369.
Nix has a builtin to generate xml called builtins.toXML

@ocharles
Copy link
Contributor

Hi @sheenobu, it looks like this pull request has fallen through the cracks. Is this pull request still relevant and important to you?

@sheenobu
Copy link
Contributor Author

Doubtful. I'm not sure how sold on the construct I or anyone else is.

@ocharles
Copy link
Contributor

@sheenobu Sorry to hear that. Should this PR remain open or be closed? I think it's best if PRs have a clear "next action".

@sheenobu
Copy link
Contributor Author

Excuse the delay I'll close it with this comment.

@sheenobu sheenobu closed this Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: nixos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sheenobu @mention-bot @Mic92 @ocharles @joachifm