Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: f0f73eab4d61
Choose a base ref
...
head repository: jruby/jruby
compare: 7424803cbb93
Choose a head ref
  • 3 commits
  • 10 files changed
  • 1 contributor

Commits on Sep 22, 2016

  1. Add paths to *DynamicScope that don't check nulls, offsets. 

    Our IR performes liveness checks on variables and should never
emit code that accesses variable indices outside the prescribed
scope size. This patch adds new getters that do not perform these
unnecessary checks, and wires up the JIT to call them.

This patch does not modify Full interpretation to use these
unchecked paths, because it would require either a boolean in
LocalVariaable operand and LoadLocalVariable instruction or a
pass to replace them with "Unchecked" versions.

It would also be better if we could generate these shapes of
DynamicScope on the fly, rather than maintaining a finite set of
mostly-identical subclasses.

See #4167.
    @headius
    headius committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    a7399b7 View commit details
    Browse the repository at this point in the history

  2. Initialize Thread name to nil. It was returning null if unset. 

    This was returning null into Ruby for any thread that did not
have a name, which could cause NullPointerException far away from
the point of call. It was masked in some cases by our
DynamicScope logic that checks for null values, but #4168 removes
those checks for the JIT.
    @headius
    headius committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    b8e019a View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4168 from headius/unchecked_dynamicscope 

    Add paths to *DynamicScope that don't check nulls, offsets.
    @headius
    headius committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    7424803 View commit details
    Browse the repository at this point in the history