-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRB: arrow keys to move along cmd line and up/down in history not working on Windows #4141
Comments
This must be due to the ^C fix we did in 9.1.3 for #3721. I don't know why it would cause this, though :-( |
A workaround for you: I believe if you install the 1.0 jruby-readline gem from here you'll restore the old behavior. @mkristian Perhaps it's time we made jruby-readline a real rubygems.org gem, so it's easier for folks to up/downgrade it as we make fixes. |
Drat...installing the 1.0 gem does not seem to fix the problem. I'll look into this today. |
Ok, here's a working workaround:
|
The jar replacement fixes the issue. I agree the jruby-readline should become a real gem as otherwise this will remain a dirty fix. |
Would this also impact pasting content? I'm seeing some extremely weird behavior there, although I haven't tried to isolate JRuby from all the other tools which might be impacting it. |
@tobymurray-nanometrics On Windows? It certainly could. |
@mkristian I tried to release a 1.1.1 gem with the regression reverted, but I'm not sure it's building the gem appropriately for rubygems.org. I can install the gem, but attempting to activate it produces the following error:
I believe it should be possible to put out a release of the gem, and get existing JRuby versions to load it by using |
jruby-readline 1.1.1 released to rubygems and maven. The current workaround is
|
This is still outstanding. @enebo: Should we revert the change to jruby-readline and release 9.1.6.0 with the reverted version? |
This is fixed with the release of jruby-readline-1.1.1, and jruby-9.1.6.0 release today will ship that. |
I can confirm this is fixed on Windows w/ |
This issue seems to be back w/ |
This is broken again on Windows w/ |
FYI this work around seems to be working (taken in part from above in this thread):
|
@hathawad may I ask which version of jruby-readline you are using ? as the version from jruby-9.1.16 should be the same (binary compatible) as jruby-readline-1.1.1 |
Hi,
The #4141 is back on Windows with jruby 9.2.0.0 :-(
I confirm using all files (not just the jar) from
jruby-readline-1.1.1-java.gem and including them in
jruby-9.2.0.0/lib/ruby/stdlib fixes the arrow keys issue on Windows.
After verifications/tests, arrow keys are working, tab completion is
working, double escape and CTRL-A/CTRL-E/CTRL-R/CTRL-U are working too.
Good catch! I can upgrade now to jruby 9.2.0.0 with this temporary fix
until it gets merged in 9.2.x
Thanks a bunch.
Christian
…On Fri, May 25, 2018 at 7:55 AM, Robert Brown ***@***.***> wrote:
@hathawad <https://github.com/hathawad> may I ask which version of
jruby-readline you are using ?
I had the same problem as @hathawad <https://github.com/hathawad> - it's
the jruby-9.1.16.0\lib\ruby\stdlib\readline.jar "version" i.e. the
standard lib not the gem. Replacing this jar with the one from the gem
install fixes it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4141 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAA9ahsn3qc4kTPyfckxP-_7z3lrW2cTks5t15zdgaJpZM4J2oOu>
.
|
@headius what is the take on this one here. are we going back to version 1.1.1 or wit until we get a reimplementation of readline ? can not remember the problems we resurrect with downgrading to 1.1.1 |
@hathawad Could you open a new issue please? We want to keep the lineage of what was "fixed" when, even if it regresses. |
Sure |
Opened #5687 for 9.2.x |
New re-re-regression. Reverting back to jline-2.11 and readline-1.1.1 did
the trick, again...
…On Wed, Apr 10, 2019 at 11:13 PM toliman7 ***@***.***> wrote:
Opened #5687 <#5687> for 9.2.x
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4141 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAA9aqUZrmzLO4P1bDCGwlCVIvWRbvCTks5vflPzgaJpZM4J2oOu>
.
|
Just to note that I am using JRuby 9.2.5.0, and also have this problem. The trick of using the jruby-readline, and copying either the one file or all the files failed to solve it; I just got an error:
|
Environment
Provide at least:
Expected Behavior
Actual Behavior
The text was updated successfully, but these errors were encountered: