New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #4147 #4153

Merged

kares merged 1 commit into jruby:master from smk0621:master

Sep 14, 2016

Contributor

smk0621 commented Sep 14, 2016 •

edited by kares

When check the OS platform, the RUBY_PLATFORM return 'java' in JRuby.
It is better to use RbConfig::CONFIG['host_os'] .

fixes #4147


          Fix JRuby issue#4147

2f9ec95

When check the OS platform, the RUBY_PLATFORM return 'java' in JRuby.

kares added this to the JRuby 9.1.6.0 milestone

kares merged commit 6ce5e55 into jruby:master

Member

enebo commented Sep 14, 2016

@headius can you commit this upstream? I don't know if they want rbconfig but this is a better check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment