Compiler: missing replace of type parameters for virtual types. Fixes #…

…3235
crystal-lang · Sep 3, 2016 · f76ac03 · f76ac03
1 parent e8ae1f9
commit f76ac03
Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/spec/compiler/semantic/generic_class_spec.cr b/spec/compiler/semantic/generic_class_spec.cr
@@ -905,4 +905,29 @@ describe "Semantic: generic class" do
       ),
       "expected type, not NumberLiteral"
   end
+
+  it "replaces type parameters for virtual types (#3235)" do
+    assert_type(%(
+      abstract class Packet(T)
+      end
+
+      abstract class OutgoingPacket(T) < Packet(T)
+      end
+
+      class Client
+      end
+
+      class Connection(T)
+        def initialize
+          @packets = Array(OutgoingPacket(T)).new
+        end
+
+        def packets
+          @packets
+        end
+      end
+
+      Connection(Client).new.packets
+      )) { generic_class "Array", generic_class("OutgoingPacket", types["Client"]).virtual_type! }
+  end
 end
diff --git a/src/compiler/crystal/types.cr b/src/compiler/crystal/types.cr
@@ -2783,6 +2783,10 @@ module Crystal
       nil
     end
 
+    def replace_type_parameters(instance)
+      base_type.replace_type_parameters(instance).virtual_type
+    end
+
     def to_s_with_options(io : IO, skip_union_parens : Bool = false, generic_args : Bool = true, codegen = false)
       base_type.to_s(io)
       io << "+"