Make getStackMax return the correct maximal stack size

SmallJoker · kwolekr · commit 2de8c22a9971 · 2016-09-08T03:37:03.000-04:00
diff --git a/src/inventory.h b/src/inventory.h
@@ -80,15 +80,14 @@ struct ItemStack
 	// Maximum size of a stack
 	u16 getStackMax(IItemDefManager *itemdef) const
 	{
-		s16 max = itemdef->get(name).stack_max;
-		return (max >= 0) ? max : 0;
+		return itemdef->get(name).stack_max;
 	}
 
 	// Number of items that can be added to this stack
 	u16 freeSpace(IItemDefManager *itemdef) const
 	{
 		u16 max = getStackMax(itemdef);
-		if(count > max)
+		if (count >= max)
 			return 0;
 		return max - count;
 	}
diff --git a/src/itemdef.h b/src/itemdef.h
@@ -61,7 +61,7 @@ struct ItemDefinition
 	/*
 		Item stack and interaction properties
 	*/
-	s16 stack_max;
+	u16 stack_max;
 	bool usable;
 	bool liquids_pointable;
 	// May be NULL. If non-NULL, deleted by destructor
diff --git a/src/script/common/c_content.cpp b/src/script/common/c_content.cpp
@@ -65,9 +65,8 @@ ItemDefinition read_item_definition(lua_State* L,int index,
 	}
 	lua_pop(L, 1);
 
-	def.stack_max = getintfield_default(L, index, "stack_max", def.stack_max);
-	if(def.stack_max == 0)
-		def.stack_max = 1;
+	int stack_max = getintfield_default(L, index, "stack_max", def.stack_max);
+	def.stack_max = rangelim(stack_max, 1, U16_MAX);
 
 	lua_getfield(L, index, "on_use");
 	def.usable = lua_isfunction(L, -1);

Original file line number	Diff line number	Diff line change
`@@ -80,15 +80,14 @@ struct ItemStack`
`80`	`80`	`// Maximum size of a stack`
`81`	`81`	`u16 getStackMax(IItemDefManager *itemdef) const`
`82`	`82`	`{`
`83`		`- s16 max = itemdef->get(name).stack_max;`
`84`		`- return (max >= 0) ? max : 0;`
	`83`	`+ return itemdef->get(name).stack_max;`
`85`	`84`	`}`
`86`	`85`
`87`	`86`	`// Number of items that can be added to this stack`
`88`	`87`	`u16 freeSpace(IItemDefManager *itemdef) const`
`89`	`88`	`{`
`90`	`89`	`u16 max = getStackMax(itemdef);`
`91`		`- if(count > max)`
	`90`	`+ if (count >= max)`
`92`	`91`	`return 0;`
`93`	`92`	`return max - count;`
`94`	`93`	`}`