Fix iconv error handling #3306
Merged
Fix iconv error handling #3306
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I didn't notice that it failed on linux/x86... |
|
@ysbaddaden Sometimes builds stall, I don't know why. I just restarted it, let's see what happens... |
|
Oh, but now we are missing an update of crystal in linux/x86 to run on travis... |
ysbaddaden
force-pushed
the
core-fix-iconv-error-handling
branch
from
37cbff2 to
a41a742
Compare
ysbaddaden
commented
Sep 26, 2016
| elsif original_to == "UTF-8" | ||
| raise ArgumentError.new("invalid encoding: #{original_from}") | ||
|
|
||
| if @iconv.address == LibC::SizeT.new(-1) |
There was a problem hiding this comment.
Gotcha: the address is architecture dependent!
There was a problem hiding this comment.
Maybe Pointer#address's type should change depending on the platform, I'm not sure.
|
@ysbaddaden Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the detection of
iconv_openreturning an error, and raises Errno wheniconv_closefails.I also added the missing Errno::E2BIG constant.
fixes #3271