-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The child-process gem fails to spawn processes on Windows #4122
Comments
Running this I can see we bomb out trying to get the handle for stdin. Something changed since 9.1.2.0 |
Tracked it down to the fix for Drip in #2690 (7e024a7) which modified stdio behavior to report actual fileno rather than always the 0, 1, 2 of typical in, out, err. This works fine on platforms where we can use native IO, but our Windows IO logic is not native yet. In addition, when running without native calls enabled, we still need to gracefully fall back and report 0, 1, 2. I have a patch in progress. |
Have fix, need tests. Not sure the best way to do this beyond just verifying that in a "simple" JRuby process, stdio has sane filenos. |
All good! |
Environment
jruby version: jruby 9.1.3.0 (2.3.1) 2016-08-29 a2a3b29 Java HotSpot(TM) 64-Bit Server VM 25.66-b18 on 1.8.0_66-b18 +jit [mswin32-x86_64]
OS: Windows 10
childprocess version: 0.5.9
Expected Behavior
Running:
... should spawn a new process. This works on jruby 9.1.2.0
Actual Behavior
This exception is raised:
Notes
I noticed that issue #2598 has an identical error message.
The text was updated successfully, but these errors were encountered: