Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a733a327c2b9
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 90413a82ed64
Choose a head ref

Commits on Aug 31, 2016

  1. extract install field helper into a standalone method (for later re-use)

    also better error messages on fails - the whole field will now be printed
    kares committed Aug 31, 2016
    Copy the full SHA
    fe0ec0e View commit details
  2. [ji] tidy-up Java field reader/writer impls - use same exception types

    - for IllegalAccessException on get/set now always map to SecurityError
    - IllegalArgumentException on field set mapped as TypeError (as before)
    kares committed Aug 31, 2016
    Copy the full SHA
    b4d13bf View commit details
  3. Copy the full SHA
    5639518 View commit details
  4. cleanup class.rb and JavaSignature - export as_java_type helper

    will know handle all primitive types correctly (inc :byte and :short) !
    and there's no reliance on internals from org.jruby.ast.java_signature.*
    kares committed Aug 31, 2016
    Copy the full SHA
    1d9f204 View commit details
  5. Copy the full SHA
    5aa263f View commit details
  6. anonymous Ruby classes should have a familiar Java class name

    ... for easier identification of which Ruby class they represent
    kares committed Aug 31, 2016
    Copy the full SHA
    84eb04f View commit details
  7. Copy the full SHA
    297a03f View commit details
  8. helpers for converting args with space left for proxy invocation-handler

    ... so that the Java (sub-class) proxy calls do not convert args twice
    
    also improved "Constructor invocation failed: " ArgumentError message
    kares committed Aug 31, 2016
    Copy the full SHA
    b6ec793 View commit details
  9. [ji] semi-optimize for 1 constructor (with arity one) in Java proxies

    ... which is the most common (having zero or one arity) to stumble upon
    
    code is dup-ed but reduces garbage generated on 'optimized' invocations
    kares committed Aug 31, 2016
    Copy the full SHA
    bcfcbbe View commit details
  10. avoid @JRubyMethod name/alias array copy-ing + review processing

    ... also AnnotationHelper can be re-used again from IndyBinder
    kares committed Aug 31, 2016
    Copy the full SHA
    77fb92b View commit details
  11. Copy the full SHA
    975cfe6 View commit details
  12. cleanum unused imports

    kares committed Aug 31, 2016
    Copy the full SHA
    1fd1a96 View commit details
  13. introduce ArraySupport helper for dealing with (small) array copy-ing

    ... arraycopy times added up on a profiling session and a quick bench
    session confirmed they can run quite faster for the usual small arrays
    kares committed Aug 31, 2016
    Copy the full SHA
    3a67809 View commit details
  14. Copy the full SHA
    90a93bc View commit details
  15. Copy the full SHA
    b2a0a59 View commit details
  16. unused runtime local var

    kares committed Aug 31, 2016
    Copy the full SHA
    805bfe4 View commit details
  17. use ArraySupport copy-ing since it will mostly be a small array

    + potentially avoid another array copy from to_ary-zed array
    kares committed Aug 31, 2016
    Copy the full SHA
    4fdbfa6 View commit details
  18. Copy the full SHA
    7680cdc View commit details
  19. extract get_with_class guts into another getProxyClass

    ... was confusing the Ruby method is now never used from JRuby
    kares committed Aug 31, 2016
    Copy the full SHA
    8c0f962 View commit details
  20. Copy the full SHA
    0d4844c View commit details
  21. Copy the full SHA
    c79157b View commit details
  22. Copy the full SHA
    58c0310 View commit details
  23. allow for (potential) JavaProxyClassFactory overrides ... as intented

    since JavaProxyClass is user-supliable make it easy for them to only
    worry about the details -> overriding newProxyClass method and not worrying about possibly changing impl internals: JavaSupportImpl
    or the runtimeTLS.
    
    renamed JavaProxyClass' get->newProxyClass for clarity ...
    method delegates to the factory's newProxyClass and now does the 
    existing Java proxy class checking on its own!
    
    also removed the "wild" Error catch (never a good idea) since we're re-throwing the 'unexpected' exceptions + added a message assertion
    kares committed Aug 31, 2016
    Copy the full SHA
    c4a44b8 View commit details
  24. Copy the full SHA
    fb74efb View commit details
  25. [test] try resolving javac from JAVA_HOME (for rake test:compile)

    ... will make sure test Java classes are compiled under same Java version
    kares committed Aug 31, 2016
    Copy the full SHA
    90413a8 View commit details
Loading