Fix IO#syswrite. Fixes #3799 #4123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etehtsea I do not see the equivalent logic in MRI's implementation, which makes me reluctant to include this. I think the actual problem may be that jnr-unixsocket is not properly doing a blocking write, or the UNIX socket is getting set non-blocking for some reason. I think we should try to investigate from the bottom up and figure out why jnr-unixsocket's write is not blocking and handling EAGAIN the same way as the write call MRI makes. |
etehtsea
force-pushed
the
gh-3799-syswrite-block
branch
from
613c99f
to
ea714e8
Compare
etehtsea
force-pushed
the
gh-3799-syswrite-block
branch
from
ea714e8
to
bfcec47
Compare
|
@headius, updated. Needs new jnr-enxio snapshot with jnr/jnr-enxio#23 merged in. |
etehtsea
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of debugging I found out that
SystemCallErrorthat happens duringsyswriteis actually"Resource temporarily unavailable"that corresponds toEAGAIN. So first idea of fix was to putselectsomewhere. Related fix forIO#sysreadgave me hope that I'm moving in right direction.As a result I did similar fix as in 857b76f