-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truffle: use jt in tests #4166
Truffle: use jt in tests #4166
Conversation
…-based tests. * Do not modify PATH. * Let jt do the proper logging, option setup, etc.
cc @jruby/truffle |
Does this let us test a standalone executable like SVM or the Ruby binary in a GraalVM build? |
It can easily, but we'll need to tell |
@chrisseaton Actually RUBY_BIN is already supported by |
Ok. My only worry is ensuring we are running what we think we are when we test. Since the command is printed that's probably fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This PR uses
jt
in test/truffle and in jtr if available. This has several advantages:@pitr-ch Please review the jtr modification to use
jt
as the "interpreter".@nirvdrum @pitr-ch I needed to introduce the equivalent of jtr's
--no-use-fs-core
injt
.I named it
--no-core-load-path
, but maybe we can use a common name, do you have any idea?Maybe
--fs-core
/--no-fs-core
?