Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truffle: use jt in tests #4166

Merged
merged 7 commits into from Sep 27, 2016
Merged

Truffle: use jt in tests #4166

merged 7 commits into from Sep 27, 2016

Conversation

eregon
Copy link
Member

@eregon eregon commented Sep 21, 2016 •
edited

This PR uses jt in test/truffle and in jtr if available. This has several advantages:

  • Can run using other launchers than bin/jruby (notably with mx, jruby_eclipse, etc).
  • Does no longer require to modify the PATH or ENV! (so commands in *.sh can be copy-pasted to CLI and work most of the cases)
  • Shows the command line used as jt does by default which helps debugging.

@pitr-ch Please review the jtr modification to use jt as the "interpreter".
@nirvdrum @pitr-ch I needed to introduce the equivalent of jtr's --no-use-fs-core in jt.
I named it --no-core-load-path, but maybe we can use a common name, do you have any idea?
Maybe --fs-core/--no-fs-core?

@eregon eregon added the truffle label Sep 21, 2016
@eregon
Copy link
Member Author

eregon commented Sep 21, 2016

cc @jruby/truffle

@chrisseaton
Copy link
Contributor

Does this let us test a standalone executable like SVM or the Ruby binary in a GraalVM build?

@eregon
Copy link
Member Author

eregon commented Sep 21, 2016

It can easily, but we'll need to tell jt to use that.
Probably using an environment variable (RUBY_BIN, RUBY_LAUNCHER)?.

@eregon
Copy link
Member Author

eregon commented Sep 21, 2016

@chrisseaton Actually RUBY_BIN is already supported by jt, so it will just need to be set when needed.

@chrisseaton
Copy link
Contributor

Ok. My only worry is ensuring we are running what we think we are when we test. Since the command is printed that's probably fine.

pitr-ch
pitr-ch approved these changes Sep 27, 2016
View reviewed changes
Copy link
Member

@pitr-ch pitr-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@eregon eregon merged commit 883bf29 into truffle-head Sep 27, 2016
@eregon eregon deleted the truffle-test-use-jt branch September 27, 2016 12:45
@enebo enebo modified the milestone: truffle-dev Nov 9, 2016
@enebo enebo added this to the Invalid or Duplicate milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitr-ch pitr-ch pitr-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Invalid or Duplicate
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eregon @chrisseaton @pitr-ch @enebo