Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: crystal-lang/crystal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 91020b31b682
Choose a base ref
...
head repository: crystal-lang/crystal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9156f797ec18
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 21, 2016

  1. Issue template: say that you should search a bug before submitting it

    Ary Borenszweig committed Sep 21, 2016

    Verified

    This commit was signed with the committer’s verified signature.
    headius Charles Oliver Nutter
    GPG key ID: 8E26FF248BC7AEAD
    Verified
    Learn about vigilant mode
    Copy the full SHA
    c208aa7 View commit details

  2. Spec: error if unknown arguments are given. Fixes #3336

    Ary Borenszweig committed Sep 21, 2016
    Copy the full SHA
    9156f79 View commit details
Showing with 8 additions and 0 deletions.
  1. +1 −0 ISSUE_TEMPLATE.md
  2. +7 −0 src/spec.cr
1 change: 1 addition & 0 deletions ISSUE_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@

Make sure to review these points before submitting issues - thank you!

- Make sure a similar issue doesn't exist yet: use the search box
- **Include reproducible code**: we should be able to paste it into an editor, compile and run it and get the same error as you. Otherwise it's impossible for us to reproduce the bug.
- Don't **only** use `play.crystal-lang.org` or `carc.in`: code might be lost and the issue will remain incomplete. Write code in the issue itself.
- Reduce code, if possible, to the minimum size that reproduces the bug.
7 changes: 7 additions & 0 deletions src/spec.cr
View file
Original file line number Diff line number Diff line change
@@ -269,6 +269,13 @@ OptionParser.parse! do |opts|
opts.on("--no-color", "Disable colored output") do
Spec.use_colors = false
end
opts.unknown_args do |args|
end
end

unless ARGV.empty?
puts "Error: unknown argument '#{ARGV.first}'"
exit 1
end

Signal::INT.trap { Spec.abort! }