libmsgpack: fixed mingw32 cross-build #18275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cmake`, as usual, should be in `nativeBuildInputs` and we need to add a few cmake flags for mingw32 build to succeed.
|
@taktoa, thanks for your PR! By analyzing the annotation information on this pull request, we identified @wkennington to be a potential reviewer |
| buildInputs = [ cmake ]; | ||
| nativeBuildInputs = [ cmake ]; | ||
|
|
||
| crossAttrs = { |
There was a problem hiding this comment.
I assume the idea here is to make it easier to add more later? I think it's cleaner to not leave hooks for future extensions.
|
LGTM, but I've added a couple minor notes for you to consider. |
joachifm
added
0.kind: enhancement
6.topic: cross-compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
cmake, as usual, should be innativeBuildInputsand we need to add a few cmake flags for mingw32 build to succeed. The cross-build was tested for all three versions of libmsgpack in nixpkgs (and the non-cross-build should be unaffected by these changes).Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)