Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OptionParser: parse arguments from shorflag if it is only referenced … #3246

Merged
merged 1 commit into from
Sep 5, 2016
Merged

OptionParser: parse arguments from shorflag if it is only referenced … #3246

merged 1 commit into from
Sep 5, 2016
+28 −1

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Sep 4, 2016

…on longflag

solves #3204

  • way to improve logic ?
  • should I use a constant for the regex instead ?
  • extract into it's own method ?

@asterite asterite added this to the 0.19.1 milestone Sep 5, 2016
@asterite
Copy link
Member

asterite commented Sep 5, 2016

@grosser Thanks, it's perfect like this.

Regex literals that don't have interpolations are already cached into a global variable so they are only compiled once, so moving them to a constant is never necessary.

@asterite asterite merged commit fa22a8d into crystal-lang:master Sep 5, 2016
@grosser grosser deleted the grosser/short-arg branch September 5, 2016 01:36
@grosser grosser mentioned this pull request Sep 5, 2016
Closed
@asterite asterite mentioned this pull request Sep 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:feature topic:stdlib
Projects
None yet
Milestone
0.19.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grosser @asterite