Fixing dependency generation for jinja templating engine. #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
requested changes
Sep 19, 2016
| @@ -112,7 +112,7 @@ def get_string_deps(self, text): | |||
| filename = self.lookup.loader.get_source(self.lookup, dep_name)[1] | |||
| deps.add(filename) | |||
| sub_deps = self.get_deps(filename) | |||
| self.dependency_cache[dep_name] = sub_deps | |||
| self.dependency_cache[dep_name] = [filename] + sub_deps | |||
There was a problem hiding this comment.
Are you sure this is the place? We return deps from this function, and it’s not taken from the cache. Perhaps add [filename] a line earlier?
There was a problem hiding this comment.
In that case, the line deps.add(filename) can go as well.
There was a problem hiding this comment.
Would be simpler to just modify sub_deps right when we define it, wouldn’t it?
There was a problem hiding this comment.
Check the current commit, is it what you want?
There was a problem hiding this comment.
Perfect, thanks. Approving and merging.
Kwpolska
approved these changes
Sep 19, 2016
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinja template dependencies sometimes miss the main template itself, depending on whether the dependencies where stored in the internal cache in
JinjaTemplates.get_string_depsor inJinjaTemplates.template_deps.