Hi @amitsaha , the code is fine.

All other help commands that have --help are because there are options or subcommands. So eventually, for consistency, other --help should be added.

I see not cons on adding this. But /etc/completion.bash and /etc/completion.zsh need to be updated also in order to update this IMO.

Another alternative for this might be to contribute to https://crystal-lang.org/docs/using_the_compiler/index.html . Maybe there is more chance for people to learn how to use eval there than in --help. Just my 2 cents.

Thanks @bcardiff for taking a look. Note that you currently get an error when you try crystal eval --help which is my main motivation for fixing this. I will do the change to the completion files and update the PR well as update the doc in a separate PR.

Can I get some help with the zsh completion?

@amitsaha Would you mind if I implement this? Adding --help for a command that doesn't have any options doesn't add much to the command, so I'll make it possible to pass --release, -s and others.

Sure. Go ahead.

Note that I was not trying to implement --help because it would add
anything. But the fact that --help would throw an error is a bug. That is
what I aimed to fix.

On 15 Sep 2016 11:26 pm, "Ary Borenszweig" notifications@github.com wrote:

@amitsaha https://github.com/amitsaha Would you mind if I implement
this? Adding --help for a command that doesn't have any options doesn't
add much to the command, so I'll make it possible to pass --release, -s
and others.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3224 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfSVmlITEQj3CiU0CGc_WssyqV6M45Bks5qqUeOgaJpZM4JySpQ
.