Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to build from Ubuntu 14.04 #3223

Closed
wants to merge 1 commit into from

Conversation

amitsaha
Copy link

@amitsaha amitsaha commented Sep 1, 2016

This makes the Dockerfile to be based on https://github.com/jhass/crystal-build-docker/tree/master/x86_64 which is the image the travis CI builds upon.

@straight-shoota
Copy link
Member

This needs to be rebased and updated to Ubuntu 16.04 @amitsaha
Otherwise this change looks resonable, since this Dockerfile actually is the source for crystallang/crystal and it makes no sense to be based on itself...

@RX14
Copy link
Contributor

RX14 commented Jun 28, 2017

@straight-shoota Actually crystallang/crystal is built from Dockerfile.release which is based on ubuntu.

@straight-shoota
Copy link
Member

straight-shoota commented Jun 28, 2017

Ok, I already found it bit strange, but then the referenced Dockerfile at dockerhub seems to be the wrong one...

@asterite
Copy link
Member

Dockerfile.release is already using Ubuntu Xenial (16.04)

@asterite asterite closed this Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants