[Truffle] Add File.lchmod

jruby · Sep 23, 2016 · 37852c0 · bjfish · Sep 23, 2016 · headius
1 parent 567e3e1
commit 37852c0
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 2 deletions.
diff --git a/spec/truffle/tags/core/file/lchmod_tags.txt b/spec/truffle/tags/core/file/lchmod_tags.txt
@@ -1,3 +1,2 @@
-fails:File.lchmod changes the file mode of the link and not of the file
 fails(linux/openbsd, not supposed to impl):File.lchmod returns false from #respond_to?
 fails(linux/openbsd, not supposed to impl):File.lchmod raises a NotImplementedError when called
diff --git a/truffle/src/main/java/org/jruby/truffle/extra/TrufflePosixNodes.java b/truffle/src/main/java/org/jruby/truffle/extra/TrufflePosixNodes.java
@@ -311,6 +311,17 @@ public int setenv(DynamicObject name, DynamicObject value, int overwrite) {
 
     }
 
+    @CoreMethod(names = "lchmod", isModuleFunction = true, required = 2, lowerFixnum = 2, unsafe = UnsafeGroup.IO)
+    public abstract static class LchmodNode extends CoreMethodArrayArgumentsNode {
+
+        @CompilerDirectives.TruffleBoundary
+        @Specialization(guards = "isRubyString(path)")
+        public int lchmod(DynamicObject path, int mode) {
+            return posix().lchmod(decodeUTF8(path), mode);
+        }
+
+    }
+
     @CoreMethod(names = "link", isModuleFunction = true, required = 2, unsafe = UnsafeGroup.IO)
     public abstract static class LinkNode extends CoreMethodArrayArgumentsNode {
 

diff --git a/truffle/src/main/java/org/jruby/truffle/platform/posix/JNRTrufflePosix.java b/truffle/src/main/java/org/jruby/truffle/platform/posix/JNRTrufflePosix.java
@@ -187,6 +187,11 @@ public SignalHandler signal(Signal sig, SignalHandler handler) {
         return posix.signal(sig, handler);
     }
 
+    @Override
+    public int lchmod(String filename, int mode) {
+        return posix.lchmod(filename, mode);
+    }
+
     @Override
     public int link(String oldpath, String newpath) {
         return posix.link(oldpath, newpath);

diff --git a/truffle/src/main/java/org/jruby/truffle/platform/posix/TrufflePosix.java b/truffle/src/main/java/org/jruby/truffle/platform/posix/TrufflePosix.java
@@ -54,6 +54,7 @@ public interface TrufflePosix {
     boolean isatty(FileDescriptor descriptor);
     int kill(int pid, int signal);
     int kill(long pid, int signal);
+    int lchmod(String filename, int mode);
     SignalHandler signal(Signal sig, SignalHandler handler);
     int link(String oldpath,String newpath);
     int lstat(String path, FileStat stat);

diff --git a/truffle/src/main/ruby/core/file.rb b/truffle/src/main/ruby/core/file.rb
@@ -247,7 +247,6 @@ def self.chmod(mode, *paths)
   # the link, not the file referenced by the link).
   # Often not available.
   def self.lchmod(mode, *paths)
-    raise NotImplementedError, "lchmod not implemented on this platform" unless Rubinius::HAVE_LCHMOD
 
     mode = Rubinius::Type.coerce_to(mode, Integer, :to_int)