Support shortcodes (Fix #172) #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
requested changes
Sep 24, 2016
| body = m2h.markmin2html(data, pretty_print=True) | ||
| out_f.write(body) | ||
| output = m2h.markmin2html(data, pretty_print=True) | ||
| output, shortcode_deps = self.site.apply_shortcodes(output, filename=source, with_dependencies=True, extra_context=dict(post=post)) |
There was a problem hiding this comment.
You aren’t getting the post object anywhere.
There was a problem hiding this comment.
Ack, I could not test the py2-only plugins. Fixing.
|
Also, could we replace all this copy-pasted boilerplate with a single function in |
|
Well, it would bw a couple of calls... I don't know. I just copy/pasted the code that works. |
Kwpolska
approved these changes
Sep 24, 2016
|
Feel free to go either way and merge if you think copy-paste will be enough. |
|
Ack, will wait for tests and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding shortcode support to almost all plugin compilers. (Issue #172)