Fixed #3332: incorrect cast placement of to_u32

crystal-lang · Sep 21, 2016 · d657b9a · kostya · Sep 21, 2016 · asterite
1 parent 9156f79
commit d657b9a
Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/spec/std/string_spec.cr b/spec/std/string_spec.cr
@@ -1979,4 +1979,11 @@ describe "String" do
       "foo".at(4)
     end
   end
+
+  it "allocates buffer of correct size when UInt8 is given to new (#3332)" do
+    String.new(255_u8) do |buffer|
+      LibGC.size(buffer).should be >= 255
+      {255, 0}
+    end
+  end
 end
diff --git a/src/string.cr b/src/string.cr
@@ -210,7 +210,7 @@ class String
   def self.new(capacity : Int)
     check_capacity_in_bounds(capacity)
 
-    str = GC.malloc_atomic((capacity + HEADER_SIZE + 1).to_u32).as(UInt8*)
+    str = GC.malloc_atomic(capacity.to_u32 + HEADER_SIZE + 1).as(UInt8*)
     buffer = str.as(String).to_unsafe
     bytesize, size = yield buffer
     str_header = str.as({Int32, Int32, Int32}*)