Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian patches #196

Closed
wants to merge 10 commits into from
Closed

Debian patches #196

wants to merge 10 commits into from

Conversation

d-lamb
Copy link
Member

@d-lamb d-lamb commented Sep 13, 2016

Applying a bunch of patches from SF.net patch 84. I have NOT applied changes patches to the files Changes or Changes_CVS, in the interest of not rewriting history.

I have not YET applied minuit_default_integer_8.patch or slatec_default_integer_8.patch, since it is not clear to me whether those changes would be portable.

But this at least allows us to test most of the patches.

Bas Couwenberg and others added 10 commits September 11, 2016 15:06
These were nearly all of the changes in spelling-errors.patch, part
of sf.net patch #84.  Not wanting to change history, I did not apply
the patches to Changes_CVS or to Changes.
Part of SF.net patch #84 from Debian: doc_dirlist.patch fixes
https://bugs.debian.org/681937: "pure-perl PDL module docs not
scanned on install".
This is patch 'manpage-has-bad-whatis-entry.patch' from SF.net
patch #84 from Debian.
SF.net patch #84 from Debian (doc_vendor_install.patch)
SF.net patch #84 from Debian, pdl-cppflags.patch.
SF.net patch #84 for Debian, patch dumper_gnukfreebsd.patch.

'gnukfreebsd' was assumed as a bsd userland, which
disabled/broke calls to 'uuencode' and 'uudecode'.
SF.net patch #84 from Debian (sorted_output.patch).

I changed it slightly from the submitted patch so that the calls
to 'sort' were on the results of 'values %hash' and not on the
result of 'map {$_->get_<whatever>} values %hash'. Merely a
stylistic preference.
SF.net patch #84, from Debian. This is part of the changeset from
reproducible-build.patch (the second one). Also partially addresses
https://bugs.debian.org/829365. Basically any time there is a
'keys %hash' or 'values %hash' in generating code, apply a 'sort'
before it. The rest of the patch is in the next commit.
Related to SF.net patch #84 from Debian (reproducibile-build.patch)
but instead of sorting the keys of PDL datatypes lexigraphically,
using PDL::Types::typesrtkeys() sorts them in order of complexity.
Satisfies the goals of reproducible builds but does it in a way
that makes more sense for PDL in this case.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.983% when pulling dcf3a23 on debian_patches into f46696c on master.

@wchristian wchristian closed this Oct 3, 2016
@wchristian wchristian deleted the debian_patches branch October 3, 2016 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants