Infer missing a type field get the type from the relationship which is in scope #4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nship which is in scope.
|
@craigmcnamara What serializer are you using? I suspect we'd like for the serializer to fill in the missing type information from the relationship before the JSONAPI document gets to this part of the internalModel. |
|
A reproduction case would also be super helpful in reviewing this PR. What payload triggers this change? |
|
@craigmcnamara any chance you can provide a sample which demonstrates the issue this PR is solving? As said above this should probably be handled by the serializer so such an information would be super helpful to track this down to the root cause. Thanks! |
|
We shouldn't be inferring, but we could do a much better job validating what we are given here. |
|
Closing in favor of #5445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep getting the error
In my debugger I was seeing a record without a type field which is what the API I'm calling returns, and there is a relationship which has the appropriate type information, but it's not being used to determine what model to load. This seems wrong to look to the record and not the application defined association, but this patch preserves existing behavior yet fixes the issue I'm hitting using an API that doesn't assert a type.