openocd: externalize jimtcl and libjaylink dependencies #18492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this pull request has bit-rotted and has conflicts. If it's still relevant, could you resolve the conflict? |
|
I tried fixing, but I can't even get it to build anymore; the build envs for all these deps are a mess. I'm just abandoning this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I was working on bumping openocd to 0.90, but was beaten to it. Absent from the recent changes are the externalization of the jimtcl and libjaylink dependencies, so here they are.
There's a FIXME in here that ought to be addressed before committing. I couldn't figure out how to get the propagatedBuildInputs included automatically in the link step, so I had to add in the
-l<lib>flags manually. How do I avoid this?Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)