Allow Windows builds using MSYS2 Environment #41
Conversation
| //Conflicts with ERROR enum defined in log.h. | ||
| #if defined(_WIN32) && defined(ERROR) | ||
| #undef ERROR | ||
| #endif |
There was a problem hiding this comment.
Why is windows.h included in this header though?
There was a problem hiding this comment.
I don't remember. Checking now; I found this out by chance when I ran the compile command with -E to look at preprocessed output.
There was a problem hiding this comment.
libusb is including it, according to the output of the following command: /C/msys64/mingw32/bin/g++.exe -H -D__USE_MINGW_ANSI_STDIO=1 -Wall -Wextra -Wcast-align -Winit-self -Wmissing-declarations -Wswitch -Wwrite-strings -std=c++11 -shared-libgcc -ggdb -c /C/msys64/home/William/src/openfpga/src/gp4prog/main.cpp 2> main.e
There was a problem hiding this comment.
Yeah, so let's kick libusb out of gp4prog.h. Just pre-declare it as struct libusb_device_handle;
There was a problem hiding this comment.
That fixes part of the problem. However, usb.cpp will need libusb, and also depends on log.h, so the ERROR identifier still needs to be undefined.
Limits the scope of the "damage", but doesn't eliminate it.
There was a problem hiding this comment.
Yeah, that's still good, because it means that nothing else that includes gp4prog.h will have the same problem.
Meant to file this weeks ago, but the following commits permit Windows builds using the MSYS2 environment.
The
doctarget doesn't work; there's a bug in MikTeX that prevents it from finding one of the 5000 packages required even though it exists on my path. My suggestion for now is to justtouchan empty file to skip doc building.I am making a pull request instead of committing directly to get feedback. Since you intend to replace the build system, this is a stopgap for now.