Remove the last of NativeException's influence. #4144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headius
force-pushed
the
kill_nativeexception
branch
3 times, most recently
from
b026b9f
to
95b9ba4
Compare
NativeException was replaced by simply rethrowing the actual Java exception some time ago, and most code did the right thing. However, a few places still threw NativeException in error along unlikely call paths (e.g. unrecoverable class lookup errors). This commit removes the last bits of NativeException use. 1. NativeException itself is stripped down to just be a simple subclass of RuntimeException in Ruby with no special backing Java object. Since it will no longer be created, code that uses it will never see it anyway. The class and its public methods remain to allow such code to compile. 2. All remaining places that threw NativeException were modified to rethrow the original exception. 3. Tests referencing NativeException were removed, along with any test utilities they alone consumed. The only remaining tests did so synthetically by constructing NativeException directly.
headius
force-pushed
the
kill_nativeexception
branch
from
95b9ba4
to
33d40df
Compare
|
I went too far...we do still create NativeException when someone uses it in a rescue, and I broke many things expecting that NativeException would never be in flight. Will have to re-attempt this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NativeException was replaced by simply rethrowing the actual Java
exception some time ago, and most code did the right thing.
However, a few places still threw NativeException in error along
unlikely call paths (e.g. unrecoverable class lookup errors).
This commit removes the last bits of NativeException use.
subclass of RuntimeException in Ruby with no special backing
Java object. Since it will no longer be created, code that
uses it will never see it anyway. The class and its public
methods remain to allow such code to compile.
to rethrow the original exception.
test utilities they alone consumed. The only remaining tests
did so synthetically by constructing NativeException directly.