Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odt2txt: 0.4 -> 0.5 #41647

Merged
merged 1 commit into from Jun 8, 2018
Merged

odt2txt: 0.4 -> 0.5 #41647

merged 1 commit into from Jun 8, 2018

Conversation

daniels
Copy link
Contributor

@daniels daniels commented Jun 7, 2018

Motivation for this change

Version 0.4 failed to build for me on MacOS 10.12.6 (16G1314). (Might be related to the removed libiconv-hacks.) Version 0.5 as specified builds cleanly.

Also 0.4 is from 2008 while 0.5 was released in 2014.

The old homepage now redirects to the GitHub repo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@daniels
odt2txt: 0.4 -> 0.5
876b640 
Version 0.4 failed to build for me on MacOS 10.12.6 (16G1314). (Might be related to the removed libiconv-hacks.) Version 0.5 as specified builds cleanly. Not tested on any other platforms though.

Also 0.4 is from 2008 while 0.5 was released in 2014.

The old homepage now redirects to the GitHub repo.
@daniels
Copy link
Contributor Author

daniels commented Jun 7, 2018

Probably should have mentioned that I didn't build this with master but with nixpkgs-unstable 18.09pre140731.c29d2fde74d.

@Mic92 Mic92 merged commit f71384c into NixOS:master Jun 8, 2018
@Mic92
Copy link
Member

Mic92 commented Jun 8, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daniels @Mic92 @GrahamcOfBorg @Janik-Haag