Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadwatch: init at 1.1 #41674

Merged
merged 2 commits into from Jun 10, 2018
Merged

loadwatch: init at 1.1 #41674

merged 2 commits into from Jun 10, 2018

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Jun 8, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: loadwatch

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6md9qjcv89s1f87lbspmw8x95wxydj6q-loadwatch-1.1
shrinking /nix/store/6md9qjcv89s1f87lbspmw8x95wxydj6q-loadwatch-1.1/bin/lw-ctl
shrinking /nix/store/6md9qjcv89s1f87lbspmw8x95wxydj6q-loadwatch-1.1/bin/loadwatch
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6md9qjcv89s1f87lbspmw8x95wxydj6q-loadwatch-1.1/bin
patching script interpreter paths in /nix/store/6md9qjcv89s1f87lbspmw8x95wxydj6q-loadwatch-1.1
checking for references to /build in /nix/store/6md9qjcv89s1f87lbspmw8x95wxydj6q-loadwatch-1.1...
/nix/store/6md9qjcv89s1f87lbspmw8x95wxydj6q-loadwatch-1.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: loadwatch

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/20srvin95139xwixac5laypksm1lrxyp-loadwatch-1.1
shrinking /nix/store/20srvin95139xwixac5laypksm1lrxyp-loadwatch-1.1/bin/lw-ctl
shrinking /nix/store/20srvin95139xwixac5laypksm1lrxyp-loadwatch-1.1/bin/loadwatch
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/20srvin95139xwixac5laypksm1lrxyp-loadwatch-1.1/bin
patching script interpreter paths in /nix/store/20srvin95139xwixac5laypksm1lrxyp-loadwatch-1.1
checking for references to /build in /nix/store/20srvin95139xwixac5laypksm1lrxyp-loadwatch-1.1...
/nix/store/20srvin95139xwixac5laypksm1lrxyp-loadwatch-1.1

stdenv.mkDerivation {
name = "loadwatch-1.1";
src = fetchurl {
url = "mirror://debian/pool/main/l/loadwatch/loadwatch_1.0+1.1alpha1.orig.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no upstream url for loadwatch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"you can get loadwatch from ftp://rplay.doit.org/pub/loadwatch/" which is gone.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not surprising, since this package is from 1998-2000 according to the sources.
Do we really want to include an 18-20 yrs old unmaintained package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xeji for having a look. At least it's still compiling, functional and the codebase is rather small. It would be easy to review. I'll try to contact the former authors. Maybe it can be revived.

adopted the source and fixed the compiler warnings
@xeji
Copy link
Contributor

xeji commented Jun 10, 2018

@GrahamcOfBorg build loadwatch

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: loadwatch

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1w03rpq86dyjxyfw9583h2b3sirbc2jd-loadwatch-1.1-1-g6d2544c
shrinking /nix/store/1w03rpq86dyjxyfw9583h2b3sirbc2jd-loadwatch-1.1-1-g6d2544c/bin/lw-ctl
shrinking /nix/store/1w03rpq86dyjxyfw9583h2b3sirbc2jd-loadwatch-1.1-1-g6d2544c/bin/loadwatch
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1w03rpq86dyjxyfw9583h2b3sirbc2jd-loadwatch-1.1-1-g6d2544c/bin
patching script interpreter paths in /nix/store/1w03rpq86dyjxyfw9583h2b3sirbc2jd-loadwatch-1.1-1-g6d2544c
checking for references to /build in /nix/store/1w03rpq86dyjxyfw9583h2b3sirbc2jd-loadwatch-1.1-1-g6d2544c...
/nix/store/1w03rpq86dyjxyfw9583h2b3sirbc2jd-loadwatch-1.1-1-g6d2544c

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: loadwatch

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a8s8y1jj9ddwjzrabc4cdgicx1zbf3fp-loadwatch-1.1-1-g6d2544c
shrinking /nix/store/a8s8y1jj9ddwjzrabc4cdgicx1zbf3fp-loadwatch-1.1-1-g6d2544c/bin/lw-ctl
shrinking /nix/store/a8s8y1jj9ddwjzrabc4cdgicx1zbf3fp-loadwatch-1.1-1-g6d2544c/bin/loadwatch
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a8s8y1jj9ddwjzrabc4cdgicx1zbf3fp-loadwatch-1.1-1-g6d2544c/bin
patching script interpreter paths in /nix/store/a8s8y1jj9ddwjzrabc4cdgicx1zbf3fp-loadwatch-1.1-1-g6d2544c
checking for references to /build in /nix/store/a8s8y1jj9ddwjzrabc4cdgicx1zbf3fp-loadwatch-1.1-1-g6d2544c...
/nix/store/a8s8y1jj9ddwjzrabc4cdgicx1zbf3fp-loadwatch-1.1-1-g6d2544c

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: loadwatch

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@xeji
Copy link
Contributor

xeji commented Jun 10, 2018

Thanks for adopting a poor orphaned package 😃

@xeji xeji merged commit e76388a into NixOS:master Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants