Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbluray: fix Java build #41660

Merged
merged 1 commit into from Jun 8, 2018
Merged

Conversation

kylewlacy
Copy link
Contributor

Motivation for this change

The following command currently fails to build:

nix-build -E 'with import <nixpkgs> { }; libbluray.override { withJava = true; }'

That is, enabling the withJava option in libbluray fails to build, due to a patch that fails to apply. This PR updates the patch so it successfully applies to the source for libbluray v1.0.2. This patch is only applied when withJava is true.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @abbradar

@Mic92
Copy link
Member

Mic92 commented Jun 8, 2018

Thanks!

@kylewlacy kylewlacy deleted the libbluray-fix-java-build branch June 8, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants