Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiawatha: GitHub -> GitLab, clean-up #41653

Merged
merged 1 commit into from Jun 8, 2018
Merged

Conversation

Anton-Latukha
Copy link
Contributor

Developer deleted account on GitHub. As a GitLab proof - official page:
https://www.hiawatha-webserver.org/download
points to GitLab.

  • Web server officially created for mbedtls, so use bundled
  • Assert not needed
  • Build with cmake/ninja
  • Removed hack, no longer needed
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Anton-Latukha
Copy link
Contributor Author

Calling package maintainer: @ndowens

};

buildInputs = [ cmake libxslt zlib libxml2 ] ++ stdenv.lib.optional enableSSL openssl ;
buildInputs = [ cmake ninja libxslt libxml2 ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least cmake and ninja should go to nativeBuildInputs.

Developer deleted account on GitHub. As a GitLab proof - official page:
https://www.hiawatha-webserver.org/download
points to GitLab.

* Web server officially created for mbedtls, use bundled
* Assert not needed
* Build with cmake/ninja
* Removed hack, no longer needed
@jtojnar
Copy link
Contributor

jtojnar commented Jun 8, 2018

We should probably add those flags and build this with mbedtls.

@Anton-Latukha Anton-Latukha deleted the hiawatha branch June 8, 2018 15:20
@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Jun 8, 2018

Do make this flags:

"MBEDTLS_THREADING_PTHREAD MBEDTLS_THREADING_C" enabled

default in mbedtls?

Seems like a reasonable thing.

mbedtls also has test suite written in Perl. Should I enable it. If so, launch tests as postinstall, or make it into a test.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 9, 2018

Sounds good to me.

Enabling test suite is also always good if it is not too much hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants