Better draft handling #2415
Merged
Better draft handling #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is useful for plugins that may want to implement their own toolbar (and thus hide the default toolbar), but still would like to let the locktimer set the draft status.
Plugins may want to add further fields to be present when saving drafts. Plugins may want to execute some js functionality that should be timed to the saved draft/refreshed lock. If a plugin does another init() to attach the dw_locktimer to its own editor, then the default callback would be added a second time, causing unexpected and undesired behavior. This includes the changes from the following commits: 6ef45cc 6ca947f 0fff419 87bed8b
|
Re|: that failed Scrutinizer inspection: |
micgro42
added a commit
to cosmocode/dokuwiki-plugin-prosemirror
that referenced
this pull request
Jun 8, 2018
The pull request at DokuWiki has been replaced with a rewrite which implements things a bit cleaner.
splitbrain
reviewed
Jun 11, 2018
inc/Draft.php
Outdated
| protected $id; | ||
| protected $client; | ||
|
|
||
| public function __construct($ID, $client) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements many of the same features as #2413, but in a cleaner way.
This adds a new
Draftclass and uses that for all draft-related actions. The new event is now namedDRAFT_SAVEThus this replaces #2413