Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nwipe: init at 0.24 #41664

Merged
merged 2 commits into from Jun 11, 2018
Merged

nwipe: init at 0.24 #41664

merged 2 commits into from Jun 11, 2018

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Jun 8, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nwipe

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jqlh3g2ppxfi8mm2js6ya0xwf96m378c-nwipe-0.24
shrinking /nix/store/jqlh3g2ppxfi8mm2js6ya0xwf96m378c-nwipe-0.24/bin/nwipe
gzipping man pages under /nix/store/jqlh3g2ppxfi8mm2js6ya0xwf96m378c-nwipe-0.24/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jqlh3g2ppxfi8mm2js6ya0xwf96m378c-nwipe-0.24/bin
patching script interpreter paths in /nix/store/jqlh3g2ppxfi8mm2js6ya0xwf96m378c-nwipe-0.24
checking for references to /build in /nix/store/jqlh3g2ppxfi8mm2js6ya0xwf96m378c-nwipe-0.24...
/nix/store/jqlh3g2ppxfi8mm2js6ya0xwf96m378c-nwipe-0.24

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nwipe

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s2jy115b95ddz1j1ibnncclw93v9ikrn-nwipe-0.24
shrinking /nix/store/s2jy115b95ddz1j1ibnncclw93v9ikrn-nwipe-0.24/bin/nwipe
gzipping man pages under /nix/store/s2jy115b95ddz1j1ibnncclw93v9ikrn-nwipe-0.24/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s2jy115b95ddz1j1ibnncclw93v9ikrn-nwipe-0.24/bin
patching script interpreter paths in /nix/store/s2jy115b95ddz1j1ibnncclw93v9ikrn-nwipe-0.24
checking for references to /build in /nix/store/s2jy115b95ddz1j1ibnncclw93v9ikrn-nwipe-0.24...
/nix/store/s2jy115b95ddz1j1ibnncclw93v9ikrn-nwipe-0.24

xeji
xeji reviewed Jun 10, 2018
View reviewed changes
pkgs/tools/security/nwipe/default.nix Outdated
rev = "v${version}";
sha256 = "0zminjngz98b4jl1ii6ssa7pkmf4xw6mmk8apxz3xr68cps12ls0";
};
nativeBuildInputs = [ automake autoconf ncurses parted pkgconfig ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parted and ncurses should be buildInputs, not nativeBuildInputs (they don't need to run during the build).

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nwipe

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c20yyqc4jhngcjza2262gy1fpsng19f3-nwipe-0.24
shrinking /nix/store/c20yyqc4jhngcjza2262gy1fpsng19f3-nwipe-0.24/bin/nwipe
gzipping man pages under /nix/store/c20yyqc4jhngcjza2262gy1fpsng19f3-nwipe-0.24/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c20yyqc4jhngcjza2262gy1fpsng19f3-nwipe-0.24/bin
patching script interpreter paths in /nix/store/c20yyqc4jhngcjza2262gy1fpsng19f3-nwipe-0.24
checking for references to /build in /nix/store/c20yyqc4jhngcjza2262gy1fpsng19f3-nwipe-0.24...
/nix/store/c20yyqc4jhngcjza2262gy1fpsng19f3-nwipe-0.24

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nwipe

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/iylg1iz4q3yyh4j84gfm3irlhp4q21q6-nwipe-0.24
shrinking /nix/store/iylg1iz4q3yyh4j84gfm3irlhp4q21q6-nwipe-0.24/bin/nwipe
gzipping man pages under /nix/store/iylg1iz4q3yyh4j84gfm3irlhp4q21q6-nwipe-0.24/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iylg1iz4q3yyh4j84gfm3irlhp4q21q6-nwipe-0.24/bin
patching script interpreter paths in /nix/store/iylg1iz4q3yyh4j84gfm3irlhp4q21q6-nwipe-0.24
checking for references to /build in /nix/store/iylg1iz4q3yyh4j84gfm3irlhp4q21q6-nwipe-0.24...
/nix/store/iylg1iz4q3yyh4j84gfm3irlhp4q21q6-nwipe-0.24

@xeji xeji merged commit ed657a9 into NixOS:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woffs @GrahamcOfBorg @xeji