Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcsclite: use canonical src url #41869

Closed
wants to merge 1 commit into from
Closed

pcsclite: use canonical src url #41869

wants to merge 1 commit into from

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jun 11, 2018 •
edited

As pointed out by @ookhoi in #41790,
there's a standard upstream URL that we should be using instead of the debian
mirror.

This is a better fix than the initial one merged in c256347.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bhipple
pcsclite: use canonical src url
ea3df42 
As pointed out by @ookhoi in NixOS#41790,
there's a standard upstream URL that we should be using instead of the debian
mirror.

This is a better fix than the initial one merged in c256347.
@bhipple
Copy link
Contributor Author

bhipple commented Jun 11, 2018

@GrahamcOfBorg build pcsclite

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pcsclite

Partial log (click to expand)

shrinking /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23/lib/libpcscspy.so.0.0.0
shrinking /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23/lib/libpcsclite.so.1.0.0
shrinking /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23/sbin/pcscd
gzipping man pages under /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23/lib  /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23/bin  /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23/sbin
patching script interpreter paths in /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23
/nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23/bin/pcsc-spy: interpreter directive changed from " /usr/bin/python" to "/nix/store/nwsww2h72aa6040sg3yzprl9qrhkgymx-python-2.7.15/bin/python"
checking for references to /build in /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23...
moving /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23/sbin/* to /nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23/bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pcsclite

Partial log (click to expand)

/nix/store/9s7jds3gaf0nb5jyb0iii57m4v2q0jf8-pcsclite-1.8.23

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pcsclite

Partial log (click to expand)

shrinking /nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23/lib/libpcsclite.so.1.0.0
shrinking /nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23/lib/libpcscspy.so.0.0.0
gzipping man pages under /nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23/share/man/
strip is /nix/store/3ki967c3ij4zi1q9ycc3g1vfwr608nrb-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23/lib  /nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23/bin  /nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23/sbin
patching script interpreter paths in /nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23
/nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23/bin/pcsc-spy: interpreter directive changed from " /usr/bin/python" to "/nix/store/l2bzfyyrhdkllnz85zp2nm2x1qzg47vl-python-2.7.15/bin/python"
checking for references to /build in /nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23...
moving /nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23/sbin/* to /nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23/bin
/nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pcsclite

Partial log (click to expand)

these derivations will be built:
  /nix/store/ragilcwqii2dhp5d4m4dcp2zb66pwsd9-guile-2.0.13.drv
  /nix/store/kriy5x9163339vrq6f7x8y54y1273xzz-autogen-5.18.12.drv
  /nix/store/qgv8dp0c16v4s29k89q7yrg6c9niy88c-gnutls-3.6.2.drv
  /nix/store/bsxkkxp1v7p2mlz98jw53x8l10i3q9zx-libmicrohttpd-0.9.59.drv
  /nix/store/g4mm1w7fgv6g74w67w8vw99690kw9vz1-systemd-238.drv
  /nix/store/cqgq5wgjzs3hkfcv8cmwsq9a91ihm8vp-dbus-1.12.8.drv
  /nix/store/5q3wgpjfb8x8q6c9qbiygdp3h22ra87f-pcsclite-1.8.23.drv
waiting for locks or build slots...
/nix/store/7c5s2n8rjscswqrypkwn2sv6j5hq72cq-pcsclite-1.8.23

orivej added a commit that referenced this pull request Jun 12, 2018
@orivej
Revert "pcsclite: fix URL for debian move to gitlab"
2ed34da 
This reverts commit c256347 on staging.

The issue was fixed on master in #41790 (aa18847)

Closes #41869
@orivej
Copy link
Contributor

orivej commented Jun 12, 2018

Fixed in 2ed34da on staging and 4d5565e on master, and merged master into staging.

@orivej orivej closed this Jun 12, 2018
@bhipple
Copy link
Contributor Author

bhipple commented Jun 12, 2018 •
edited

Thanks @orivej!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @GrahamcOfBorg @orivej