Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: 0.2.2 -> 0.3.0 #41873

Merged
merged 2 commits into from Jun 12, 2018
Merged

neovim: 0.2.2 -> 0.3.0 #41873

merged 2 commits into from Jun 12, 2018

Conversation

colemickens
Copy link
Member

Motivation for this change

v0.3.0 was released today

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@colemickens colemickens mentioned this pull request Jun 12, 2018
Closed
@andir
Copy link
Member

andir commented Jun 12, 2018

@GrahamcOfBorg build neovim

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: neovim

Partial log (click to expand)

  cmake/FindIconv.cmake:18 (libfind_process)
  CMakeLists.txt:433 (find_package)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-neovim-unwrapped-0.3.0.drv-0/source/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-neovim-unwrapped-0.3.0.drv-0/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/0pbwr0wqk2ldbfanhkdz30i1r6aymwbg-neovim-unwrapped-0.3.0.drv' failed with exit code 1
cannot build derivation '/nix/store/qz1a203n45y8zy2fifb8q68lmhdrm1bd-neovim-0.3.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/qz1a203n45y8zy2fifb8q68lmhdrm1bd-neovim-0.3.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: neovim

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xr6hr01ym9adgj7hjicjhngingbfdwr6-neovim-unwrapped-0.3.0
shrinking /nix/store/xr6hr01ym9adgj7hjicjhngingbfdwr6-neovim-unwrapped-0.3.0/bin/nvim
gzipping man pages under /nix/store/xr6hr01ym9adgj7hjicjhngingbfdwr6-neovim-unwrapped-0.3.0/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xr6hr01ym9adgj7hjicjhngingbfdwr6-neovim-unwrapped-0.3.0/bin
patching script interpreter paths in /nix/store/xr6hr01ym9adgj7hjicjhngingbfdwr6-neovim-unwrapped-0.3.0
/nix/store/xr6hr01ym9adgj7hjicjhngingbfdwr6-neovim-unwrapped-0.3.0/share/nvim/runtime/macros/less.sh: interpreter directive changed from "/bin/sh" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/xr6hr01ym9adgj7hjicjhngingbfdwr6-neovim-unwrapped-0.3.0...
building '/nix/store/wf81nzsszm9mzzsc3pn0mpihnp2rksjn-neovim-0.3.0.drv'...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: neovim

Partial log (click to expand)

        /build/source/src/nvim/generators/gen_declarations.lua:255: in main chunk
        [C]: at 0x00405660
make[2]: *** [src/nvim/CMakeFiles/nvim.dir/build.make:253: src/nvim/auto/eval/encode.c.generated.h] Error 1
make[1]: *** [CMakeFiles/Makefile2:2865: src/nvim/CMakeFiles/nvim.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[100%] Built target tty-test
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/g76lcg5l56fza9jc4zdb46s088qq45a8-neovim-unwrapped-0.3.0.drv' failed with exit code 2
cannot build derivation '/nix/store/94kj7nh1cd1ksrsqxjr5d7zybiwa4rb3-neovim-0.3.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/94kj7nh1cd1ksrsqxjr5d7zybiwa4rb3-neovim-0.3.0.drv' failed

Mic92
Mic92 reviewed Jun 12, 2018
View reviewed changes
pkgs/applications/editors/neovim/default.nix
@@ -32,6 +32,7 @@ let
luaPackages.lua
gperf
] ++ optional withJemalloc jemalloc
++ optional stdenv.isDarwin libiconv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a blind fix. Let's see if it works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we almost always want to unconditionally add libiconv. Things like musl will also need it as well.

@Mic92
Copy link
Member

Mic92 commented Jun 12, 2018

@GrahamcOfBorg build neovim

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: neovim

Partial log (click to expand)

/nix/store/rqv535js21r6g8q5l2vjcrmpnkhiap4l-neovim-0.3.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: neovim

Partial log (click to expand)

stack traceback:
        [C]: in function 'match'
        /build/source/src/nvim/generators/gen_declarations.lua:255: in main chunk
        [C]: at 0x00405660
make[2]: *** [src/nvim/CMakeFiles/nvim.dir/build.make:730: src/nvim/auto/os/env.c.generated.h] Error 1
make[1]: *** [CMakeFiles/Makefile2:2865: src/nvim/CMakeFiles/nvim.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/g76lcg5l56fza9jc4zdb46s088qq45a8-neovim-unwrapped-0.3.0.drv' failed with exit code 2
cannot build derivation '/nix/store/94kj7nh1cd1ksrsqxjr5d7zybiwa4rb3-neovim-0.3.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/94kj7nh1cd1ksrsqxjr5d7zybiwa4rb3-neovim-0.3.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: neovim

Partial log (click to expand)

-- Installing: /nix/store/89yf0hjfzgjmnjfa2kinz9cxxyih3m6k-neovim-unwrapped-0.3.0/share/nvim/runtime/tutor/tutor.tutor
-- Installing: /nix/store/89yf0hjfzgjmnjfa2kinz9cxxyih3m6k-neovim-unwrapped-0.3.0/share/nvim/runtime/tutor/en/vim-01-beginner.tutor.json
-- Installing: /nix/store/89yf0hjfzgjmnjfa2kinz9cxxyih3m6k-neovim-unwrapped-0.3.0/share/nvim/runtime/tutor/tutor.tutor.json
post-installation fixup
gzipping man pages under /nix/store/89yf0hjfzgjmnjfa2kinz9cxxyih3m6k-neovim-unwrapped-0.3.0/share/man/
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/89yf0hjfzgjmnjfa2kinz9cxxyih3m6k-neovim-unwrapped-0.3.0/bin
patching script interpreter paths in /nix/store/89yf0hjfzgjmnjfa2kinz9cxxyih3m6k-neovim-unwrapped-0.3.0
/nix/store/89yf0hjfzgjmnjfa2kinz9cxxyih3m6k-neovim-unwrapped-0.3.0/share/nvim/runtime/macros/less.sh: interpreter directive changed from "/bin/sh" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/sh"
building '/nix/store/pz6mdx1y12cxc5h2rp1pcck4k4hpln9s-neovim-0.3.0.drv'...

@Mic92 Mic92 mentioned this pull request Jun 12, 2018
Merged
@Mic92
Copy link
Member

Mic92 commented Jun 12, 2018

aarch64 failed already before that.

@Mic92 Mic92 merged commit 552d079 into NixOS:master Jun 12, 2018
@colemickens
Copy link
Member Author

Thanks @Mic92 !

@colemickens colemickens deleted the master branch June 12, 2018 19:52
@xeji xeji mentioned this pull request Jun 13, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@colemickens @andir @GrahamcOfBorg @Mic92 @matthewbauer